feat(deps): upgrade vite-task for compact task runner summary#623
Merged
branchseer merged 8 commits intomainfrom Feb 25, 2026
Merged
feat(deps): upgrade vite-task for compact task runner summary#623branchseer merged 8 commits intomainfrom
branchseer merged 8 commits intomainfrom
Conversation
fengmk2
reviewed
Feb 24, 2026
Member
fengmk2
left a comment
fengmk2
left a comment
There was a problem hiding this comment.
should add snap tests for --verbose and --last-details options?
Member
Author
@fengmk2 |
fengmk2
approved these changes
Feb 24, 2026
branchseer
force-pushed
the
feat/improve-task-runner-summary
branch
2 times, most recently
from
0bb750a to
7807bcb
Compare
Upgrade vite-task to voidzero-dev/vite-task#171 which replaces the verbose full execution summary with compact one-liners. Single-task runs with no cache hit show no summary. Single-task cache hits show a brief 'cache hit' message. Multi-task runs show hit rate and time saved, with a hint to use --verbose for full details. Updates cli.rs to use ParsedCommand (now exposed by vite-task) with .into_command() at dispatch points, and regenerates 25 snap tests.
- Update vite-task to 7d49f24f (summary-output e2e tests, fspy revert) - Strip ANSI escape codes in replaceUnstableOutput — third-party tools like rolldown emit ANSI on stderr even with NO_COLOR, causing [33m fragments in snap output on Linux/Windows - Add .gitignore with 'node_modules' to ignore_dist, plain-terminal-ui-nested, and oxlint-typeaware fixtures to prevent oxlint from traversing node_modules/.vite/task-cache (causes spurious cache misses) - Update ignore_dist snap: now correctly shows cache hit after adding .gitignore - Update command-helper/command-vp-alias snaps: ANSI stripped from clap help output
The ANSI stripping added in 4754dbc was incorrect — the empty PR #625 proves rolldown doesn't break tests. The real issue was that clap help text contains ANSI codes which should be preserved in snapshots as-is. Changes: - Revert ANSI escape code stripping from replaceUnstableOutput - Restore command-helper and command-vp-alias snaps with ANSI codes - Update vite-task rev to cc005960 (includes flush fix for reporter) - Update cache-scripts-default snap: flush fix makes script stdout visible via Stdio::inherit() - Remove temporary local vite-task patch from Cargo.toml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… filtering - Add ANSI escape code stripping to replaceUnstableOutput() to handle third-party tools (rolldown reporter, clap) that emit ANSI codes regardless of NO_COLOR - Strip ANSI codes from all 18 committed snap files to match - Use `2>&1 | grep` in cache-scripts-default and command-pack-monorepo to filter out platform-inconsistent child output and cached stderr ANSI codes that bypass stdout-only grep pipes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- command-env-which: versions in "Version:" and "Node:" fields are now matched by semver regex after ANSI codes that previously hid them are stripped - cache-scripts-default: remove trailing blank line to match snap test output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ANSI codes in snap files are deterministic and stable across platforms. The only fixes needed are `2>&1 | grep` in the two tests where cached stderr or Stdio::inherit() output leaks past stdout-only grep pipes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update vite-task to 24baf0b3 which renames `ParsedCommand` to `Command` and makes resolved dispatch types internal. Remove `.into_command()` calls that are no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
branchseer
force-pushed
the
feat/improve-task-runner-summary
branch
from
9773148 to
ef67fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.rsto useParsedCommand(now exposed by vite-task) with.into_command()at dispatch pointsNew behavior
---+[vp run] cache hit, {duration} saved.---+[vp run] {hits}/{total} cache hit ({rate}%), {duration} saved. (Run 'vp run --verbose' for full details)New CLI flags
-v/--verbose: Show full execution summary (previous default behavior)--last-details: Display saved summary from last runDepends on: voidzero-dev/vite-task#171